Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upload.Dragger triggered by label when disabled #24202

Merged
merged 2 commits into from May 16, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 16, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24197

💡 Background and solution

#16483 didn't handle Upload.Dragger.

📝 Changelog

Language Changelog
🇺🇸 English Avoid disabled Upload.Dragger being triggered by clicking Form label.
🇨🇳 Chinese 修复 Upload.Dragger 禁用时依然会被 Form label 触发的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 16, 2020

@afc163 afc163 merged commit a820046 into master May 16, 2020
25 of 30 checks passed
@afc163 afc163 deleted the fix-upload-dragger branch May 16, 2020
afc163 added a commit that referenced this issue May 16, 2020
* refactor Dragger.tsx

* 🐛 Avoid disabled Upload.Dragger being triggered by label

close #24197
LukerSpringtree pushed a commit to LukerSpringtree/ant-design that referenced this issue Aug 23, 2021
* refactor Dragger.tsx

* 🐛 Avoid disabled Upload.Dragger being triggered by label

close ant-design#24197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants