Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(alert): rewrite with hook and support strict mode #24236

Merged
merged 3 commits into from May 19, 2020

Conversation

hengkx
Copy link
Member

@hengkx hengkx commented May 18, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English refactor with hook and support strict mode
🇨🇳 Chinese 用 react hook 重构,支持严格模式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@hengkx hengkx added this to WIP in Refactor with React Hooks via automation May 18, 2020
@hengkx hengkx added this to WIP in React 18 & StrictMode Support via automation May 18, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 18, 2020

@codecov
Copy link

@codecov codecov bot commented May 18, 2020

Codecov Report

Merging #24236 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24236      +/-   ##
==========================================
- Coverage   98.81%   98.81%   -0.01%     
==========================================
  Files         363      363              
  Lines        7280     7269      -11     
  Branches     2006     2015       +9     
==========================================
- Hits         7194     7183      -11     
  Misses         86       86              
Impacted Files Coverage Δ
components/alert/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c99ecda...b39e5f1. Read the comment docs.

@hengkx hengkx requested review from afc163, saeedrahimi and zombieJ May 18, 2020
components/alert/index.tsx Outdated Show resolved Hide resolved
@hengkx hengkx requested a review from zombieJ May 18, 2020
components/alert/index.tsx Outdated Show resolved Hide resolved
@hengkx hengkx requested a review from zombieJ May 19, 2020
@zombieJ zombieJ merged commit 706f0bb into master May 19, 2020
33 of 34 checks passed
Refactor with React Hooks automation moved this from WIP to Done May 19, 2020
React 18 & StrictMode Support automation moved this from WIP to Done May 19, 2020
@zombieJ zombieJ deleted the refactor/alert branch May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants