Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Drawer cover other elements when closed #24290

Merged
merged 2 commits into from
May 19, 2020
Merged

fix: Drawer cover other elements when closed #24290

merged 2 commits into from
May 19, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 19, 2020 •
edited
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24287

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer cover background elements when it is not visible.
🇨🇳 Chinese 修复 Drawer 关闭后依然会遮挡页面元素的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/drawer/demo/basic-right.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 19, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #24290 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24290   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         363      363           
  Lines        7280     7282    +2     
  Branches     1972     1973    +1     
=======================================
+ Hits         7195     7197    +2     
  Misses         85       85
Impacted Files Coverage Δ
components/drawer/index.tsx 98.86% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update baa56b6...942e550. Read the comment docs.

@yoyo837
Copy link
Contributor

yoyo837 commented May 19, 2020

会闪

@afc163
Copy link
Member Author

afc163 commented May 19, 2020

现在可以了。

@yoyo837
Copy link
Contributor

yoyo837 commented May 19, 2020

没有无mask的demo了

@afc163
Copy link
Member Author

afc163 commented May 19, 2020

原来也没有。

@yoyo837
Copy link
Contributor

yoyo837 commented May 19, 2020 •
edited
Loading

加一个如何？

在这个地方加个switch 开启或者关闭mask。
image

@afc163
Copy link
Member Author

afc163 commented May 19, 2020

加个了 debug 用的 demo。

afc163
afc163 commented May 19, 2020
View reviewed changes
components/drawer/demo/no-mask.md
title:
zh-CN: 无遮罩
en-US: No mask
debug: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

调试专用。

@afc163 afc163 merged commit 6ad1b18 into master May 19, 2020
@afc163 afc163 deleted the fix-drawer branch May 19, 2020 10:11
@chenshuai2144 chenshuai2144 mentioned this pull request May 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyo837 yoyo837 yoyo837 left review comments

Assignees

@afc163 afc163

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drawer在在底部无遮罩时关闭问题
3 participants
@afc163 @ant-design-bot @yoyo837