-
-
Notifications
You must be signed in to change notification settings - Fork 51.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Notification hooks #24337
fix: Notification hooks #24337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #24337 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 363 363
Lines 7271 7272 +1
Branches 2022 2022
=======================================
+ Hits 7186 7187 +1
Misses 85 85
Continue to review full report at Codecov.
|
这个 changelog 写的不好,没有从用户角度出发。 |
嗯,我写的时候也很纠结。不知道怎么写更好些。 |
试着写了一下:#24410 (comment) |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #24334
💡 Background and solution
📝 Changelog
useNotification
api instance to be same instance for each render.useNotification
api 实例在每次渲染时都返回相同实例。☑️ Self Check before Merge