Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Table selection cache #24338

Merged
merged 2 commits into from May 21, 2020
Merged

fix: Table selection cache #24338

merged 2 commits into from May 21, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 21, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24336

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Table rowSelection.onChange return removed records by dataSource.
🇨🇳 Chinese 修复 Table 在 dataSource 移除条目时,rowSelection.onChange 任然会缓存的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 21, 2020

@codecov
Copy link

@codecov codecov bot commented May 21, 2020

Codecov Report

Merging #24338 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24338   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         363      363           
  Lines        7272     7278    +6     
  Branches     2022     1975   -47     
=======================================
+ Hits         7187     7193    +6     
  Misses         85       85           
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 98.36% <100.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e613861...6492e1f. Read the comment docs.

@zombieJ zombieJ merged commit 0689982 into master May 21, 2020
33 checks passed
@zombieJ zombieJ deleted the fix-selection branch May 21, 2020
@damiangreen
Copy link
Contributor

@damiangreen damiangreen commented Jun 3, 2020

I believe this fix has broken functionality we rely on.

@zombieJ
Copy link
Member Author

@zombieJ zombieJ commented Jun 3, 2020

@damiangreen pls feel free to fire an issue if any bug you meet.

@damiangreen
Copy link
Contributor

@damiangreen damiangreen commented Jun 3, 2020

There is one already but it got closed too quickly.. can we re-open it
#24640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants