-
-
Notifications
You must be signed in to change notification settings - Fork 51.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Table selection cache #24338
fix: Table selection cache #24338
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## master #24338 +/- ##
=======================================
Coverage 98.83% 98.83%
=======================================
Files 363 363
Lines 7272 7278 +6
Branches 2022 1975 -47
=======================================
+ Hits 7187 7193 +6
Misses 85 85
Continue to review full report at Codecov.
|
I believe this fix has broken functionality we rely on. |
@damiangreen pls feel free to fire an issue if any bug you meet. |
There is one already but it got closed too quickly.. can we re-open it |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve #24336
💡 Background and solution
📝 Changelog
rowSelection.onChange
return removed records bydataSource
.dataSource
移除条目时,rowSelection.onChange
任然会缓存的问题。☑️ Self Check before Merge