feat: add avatar gap api #24357
Merged
feat: add avatar gap api #24357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
哥，录gif软件是什么？ |
Mac 我用 Gifox |
afc163
reviewed
May 21, 2020
| @@ -439,6 +439,7 @@ exports[`renders ./components/avatar/demo/dynamic.md correctly 1`] = ` | |||
| <div> | |||
| <span | |||
| class="ant-avatar ant-avatar-lg ant-avatar-circle" | |||
| gap="4" | |||
afc163
reviewed
May 21, 2020
components/avatar/index.tsx
Outdated
| } | ||
|
|
||
| if (this.lastGap !== gap) { | ||
| this.lastGap = gap; |
afc163
reviewed
May 21, 2020
components/avatar/index.zh-CN.md
Outdated
| @@ -22,3 +22,4 @@ title: Avatar | |||
| | srcSet | 设置图片类头像响应式资源地址 | string | - | | | |||
| | alt | 图像无法显示时的替代文本 | string | - | | | |||
| | onError | 图片加载失败的事件，返回 false 会关闭组件默认的 fallback 行为 | () => boolean | - | | | |||
| | gap | 字符类型距离左右两侧边界间隙 | number | 4 | 4.3.0 | | |||
xrkffgg
commented
May 23, 2020
| ) { | ||
| return; |
There was a problem hiding this comment.
当 childrenWidth 和 nodeWidth 都不变，只修改 gap 时候，不加这个 lastGap ，就直接 return 了
@afc163
xrkffgg
force-pushed
the
add-avatar-sizePadding
branch
from
e44ed98
to
ad1497f
Compare
xrkffgg
force-pushed
the
add-avatar-sizePadding
branch
from
2bd9712
to
568a6e2
Compare
Codecov Report
@@ Coverage Diff @@
## feature #24357 +/- ##
========================================
Coverage 98.75% 98.75%
========================================
Files 364 364
Lines 7409 7411 +2
Branches 2007 2010 +3
========================================
+ Hits 7317 7319 +2
Misses 92 92
Continue to review full report at Codecov.
|
|
/rebase |
afc163
approved these changes
May 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
#24330 (comment)
Demo show
📝 Changelog
gapto set the unit distance between left and right sides.gap来设置字符类型距离左右两侧边界单位像素。☑️ Self Check before Merge
View rendered components/avatar/demo/dynamic.md
View rendered components/avatar/index.en-US.md
View rendered components/avatar/index.zh-CN.md