Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Input.TextArea clear icon disappears #24360

Merged
merged 2 commits into from May 21, 2020
Merged

Conversation

daolou
Copy link
Contributor

@daolou daolou commented May 21, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24359

💡 Background and solution

Background:
The clear icon disappears when Input.TextArea hover in Input.Group.

solution:
set css style in components/input/style/allow-clear.less : z-index.

.@{ant-prefix}-input-textarea-clear-icon {
  // ...
  z-index: 1;
  // ...
}

📝 Changelog

Language Changelog
🇺🇸 English Fix Input.TextArea clear icon disappears in Input.Group when hover it.
🇨🇳 Chinese 修复 Input.Group 内 Input.TextArea hover 时清除图标消失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 21, 2020

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 21, 2020

Input.Group 建议尽量只放 Input吧。

@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

Input.Group 建议尽量只放 Input吧。

关键是有这种场景啊,批量操作的时候

@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented May 21, 2020

CI failed

@yoyo837 yoyo837 changed the title [#24359]: fix this issues fix: fix issue #24359 May 21, 2020
@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

CI failed

我在提一次吧,有样式order问题

@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

不用新开PR,直接在你这个分支继续修改再push即可

嗯,看到效果了,这里自动了

@codecov
Copy link

@codecov codecov bot commented May 21, 2020

Codecov Report

Merging #24360 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24360   +/-   ##
=======================================
  Coverage   98.83%   98.83%           
=======================================
  Files         363      363           
  Lines        7278     7278           
  Branches     2024     2023    -1     
=======================================
  Hits         7193     7193           
  Misses         85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3629830...80ee382. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 21, 2020

@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

请按模板写 PR 内容:https://github.com/ant-design/ant-design/blob/master/.github/PULL_REQUEST_TEMPLATE.md

更新了一下,看看合格否?

有哪些地方不ok的,请指出来,我也好对应纠正

@afc163
Copy link
Member

@afc163 afc163 commented May 21, 2020

  1. 中英文之间加空格。
  2. 加句号。
- 修复 Input.Group 包裹 Input.TextArea后没法清除的bug
+ 修复 Input.Group 内 Input.TextArea `hover` 时清除图标消失的问题。

英文也一并改下。

@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

  1. 中英文之间加空格。
  2. 加句号。
- 修复 Input.Group 包裹 Input.TextArea后没法清除的bug
+ 修复 Input.Group 内 Input.TextArea `hover` 时清除图标消失的问题。

英文也一并改下。

🧐 啊啊啊啊啊,仿佛回到写毕业论文的时候了,👀

请在 check 一次

@afc163
Copy link
Member

@afc163 afc163 commented May 21, 2020

Input.TextArea 组件不用加 `

@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

Input.TextArea 组件不用加 `

ok 啦

@afc163
Copy link
Member

@afc163 afc163 commented May 21, 2020

image

标题写的有意义一点,用英文。

@afc163
Copy link
Member

@afc163 afc163 commented May 21, 2020

- Fix the problem that the clear icon disappears when Input.TextArea `hover` in Input.Group. 
+ Fix Input.TextArea clear icon disappears in Input.Group when hover it.

@daolou daolou changed the title fix: fix issue #24359 fix: Fix Input.TextArea clear icon disappears in Input.Group when hover it. May 21, 2020
@daolou daolou changed the title fix: Fix Input.TextArea clear icon disappears in Input.Group when hover it. Fix: Input.TextArea clear icon disappears in Input.Group when hover it. May 21, 2020
@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

- Fix the problem that the clear icon disappears when Input.TextArea `hover` in Input.Group. 
+ Fix Input.TextArea clear icon disappears in Input.Group when hover it.

请 check

@daolou daolou changed the title Fix: Input.TextArea clear icon disappears in Input.Group when hover it. style: Fix Input.TextArea clear icon disappears in Input.Group when hover it. May 21, 2020
@afc163 afc163 changed the title style: Fix Input.TextArea clear icon disappears in Input.Group when hover it. style: Fix Input.TextArea clear icon disappears May 21, 2020
@afc163 afc163 changed the title style: Fix Input.TextArea clear icon disappears fix: Input.TextArea clear icon disappears May 21, 2020
@afc163 afc163 merged commit 4066f2f into ant-design:master May 21, 2020
21 of 22 checks passed
@daolou
Copy link
Contributor Author

@daolou daolou commented May 21, 2020

@afc163 感谢偏右老师的指导 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants