feat: add custom expand style for typography.paragraph #24385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
|
|
Shoud I add some test cases or example for this change? |
|
ci broken |
|
fixed~ |
fireairforce
force-pushed
the
feature-typography
branch
from
cc1deee to
45c690e
Compare
Codecov Report
@@ Coverage Diff @@
## feature #24385 +/- ##
========================================
Coverage 98.96% 98.96%
========================================
Files 364 364
Lines 7405 7408 +3
Branches 2058 2060 +2
========================================
+ Hits 7328 7331 +3
Misses 77 77
Continue to review full report at Codecov.
|
|
测试覆盖率要补一下。 |
|
好的。 |
fireairforce
force-pushed
the
feature-typography
branch
from
45c690e to
8af30ce
Compare
|
@afc163 PTAL |
afc163
reviewed
May 26, 2020
components/typography/index.zh-CN.md
Outdated
| @@ -54,7 +54,7 @@ cols: 1 | |||
| | delete | 添加删除线样式 | boolean | false | | | |||
| | disabled | 禁用文本 | boolean | false | | | |||
| | editable | 是否可编辑，为对象时可对编辑进行控制 | boolean \| { editing: boolean, onStart: Function, onChange: Function(string) } | false | | | |||
| | ellipsis | 自动溢出省略，为对象时可设置省略行数、是否可展开、添加后缀等 | boolean \| { rows: number, expandable: boolean, suffix: string, onExpand: Function(event), onEllipsis: Function(ellipsis) } | false | onEllipsis: 4.2.0 | | |||
| | ellipsis | 自动溢出省略，为对象时可设置省略行数、是否可展开、添加后缀等 | boolean \| { rows: number, expandable: boolean, suffix: string, symbol: string | React.ReactNode, onExpand: Function(event), onEllipsis: Function(ellipsis) } | false | onEllipsis: 4.2.0 | | |||
There was a problem hiding this comment.
Suggested change
| | ellipsis | 自动溢出省略，为对象时可设置省略行数、是否可展开、添加后缀等 | boolean \| { rows: number, expandable: boolean, suffix: string, symbol: string | React.ReactNode, onExpand: Function(event), onEllipsis: Function(ellipsis) } | false | onEllipsis: 4.2.0 | | |
| | ellipsis | 自动溢出省略，为对象时可设置省略行数、是否可展开、添加后缀等 | boolean \| { rows: number, expandable: boolean, suffix: string, symbol: React.ReactNode, onExpand: Function(event), onEllipsis: Function(ellipsis) } | false | onEllipsis: 4.2.0 | |
|
done~ |
afc163
approved these changes
May 26, 2020
|
PR 主楼要补充一下 changelog 的表格，方便发布的同学。 |
|
好的，以后会注意的~ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #17975
💡 Background and solution
add custom expand style for typography.paragraph
☑️ Self Check before Merge
View rendered components/typography/index.en-US.md
View rendered components/typography/index.zh-CN.md