Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add en_GB localisations for form #24404

Merged
merged 1 commit into from May 25, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented May 22, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#23369

💡 Background and solution

I think the validation messages for form in the UK could be the same as the US...

📝 Changelog

Language Changelog
🇺🇸 English add en_GB localisations for form
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 22, 2020

@mjfwebb
Copy link
Contributor

mjfwebb commented May 22, 2020

Yep they will be the same.

@hengkx
Copy link
Member

hengkx commented May 25, 2020

/rebase

@github-actions github-actions bot force-pushed the form-localisations-en-gb branch from eb4fdf9 to 1b0553e Compare May 25, 2020
@yoyo837
Copy link
Contributor

yoyo837 commented May 25, 2020

fork 出的不支持/rebase

@yoyo837
Copy link
Contributor

yoyo837 commented May 25, 2020

Should import from en_US?

@codecov
Copy link

codecov bot commented May 25, 2020

Codecov Report

Merging #24404 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24404   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         363      363           
  Lines        7260     7261    +1     
  Branches     1968     1968           
=======================================
+ Hits         7184     7185    +1     
  Misses         76       76           
Impacted Files Coverage Δ
components/locale/en_GB.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419004e...1b0553e. Read the comment docs.

@afc163 afc163 merged commit 84225e4 into ant-design:master May 25, 2020
17 checks passed
@morenyang morenyang deleted the form-localisations-en-gb branch May 25, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants