Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typography title prop support #24440

Merged
merged 1 commit into from May 25, 2020
Merged

fix: Typography title prop support #24440

merged 1 commit into from May 25, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented May 25, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24435

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Typography title prop support.
🇨🇳 Chinese 修复 Typography 不支持 title 属性的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 25, 2020

@kerm1it
Copy link
Member Author

@kerm1it kerm1it commented May 25, 2020

@afc163

@codecov
Copy link

@codecov codecov bot commented May 25, 2020

Codecov Report

Merging #24440 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24440   +/-   ##
=======================================
  Coverage   98.95%   98.95%           
=======================================
  Files         363      363           
  Lines        7260     7261    +1     
  Branches     1968     2016   +48     
=======================================
+ Hits         7184     7185    +1     
  Misses         76       76           
Impacted Files Coverage Δ
components/typography/Base.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 419004e...a851ee7. Read the comment docs.

@afc163 afc163 changed the title fix: support title text prop(#24435) fix: Typography title prop support May 25, 2020
@afc163 afc163 merged commit 84bd536 into ant-design:master May 25, 2020
26 checks passed
@kerm1it kerm1it deleted the fix-24435 branch May 25, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants