fix: alert close padding #24471
Merged
fix: alert close padding #24471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AshoneA 下次改的时候，记得改 RTL 鸭 |
|
|
|
|
afc163
reviewed
May 26, 2020
components/style/themes/default.less
Outdated
| @@ -856,6 +856,8 @@ | |||
| @alert-with-description-padding-vertical: @padding-md - 1px; | |||
| @alert-with-description-padding: @alert-with-description-padding-vertical 15px | |||
| @alert-with-description-no-icon-padding-vertical - 1px 64px; | |||
| @alert-with-description-padding-rtl: @alert-with-description-padding-vertical 64px | |||
There was a problem hiding this comment.
上面这个 @alert-with-description-padding 也不好，但是不好改了。
There was a problem hiding this comment.
64px 改成从这三个算出来吧，两个 padding 加一个 icon size。
There was a problem hiding this comment.
那要去掉 @alert-with-description-padding 这个变量 吗？直接放回 alert/index 里
Codecov Report
@@ Coverage Diff @@
## master #24471 +/- ##
=======================================
Coverage 99.04% 99.04%
=======================================
Files 363 363
Lines 7261 7261
Branches 2009 2009
=======================================
Hits 7192 7192
Misses 69 69 Continue to review full report at Codecov.
|
|
和 RTL 有关系么 |
RTL 只是换成了变量。其实没太大关系。 |
|
不用管 分支名 |
gotcha! |
yoyo837
reviewed
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
[中文版模板 / Chinese template]
@padding-xs是 8pxpadding.padding。