Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Breadcrumb link margin #24490

Merged
merged 5 commits into from May 27, 2020
Merged

Conversation

EscapeB
Copy link
Contributor

@EscapeB EscapeB commented May 27, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24483

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Breadcrumb icon margin missing when using links.
🇨🇳 Chinese 修复 Breadcrumb 内使用链接时图标间距丢失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 27, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 27, 2020

@codecov
Copy link

@codecov codecov bot commented May 27, 2020

Codecov Report

Merging #24490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24490   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         363      363           
  Lines        7230     7230           
  Branches     1966     2013   +47     
=======================================
  Hits         7165     7165           
  Misses         65       65           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e96b9e...37858d9. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented May 27, 2020

- breadcrumb < a > 标签添加间距
+ 修复 Breadcrumb 内使用链接时图标间距丢失的问题。

英文同理。

@afc163 afc163 changed the title fix: breadcrumb a 标签添加间距 fix: Breadcrumb link margin May 27, 2020
Co-authored-by: 偏右 <afc163@gmail.com>
components/breadcrumb/style/rtl.less Outdated Show resolved Hide resolved
Copy link
Member

@afc163 afc163 left a comment

- breadcrumb < a > 标签添加间距
+ 修复 Breadcrumb 内使用链接时图标间距丢失的问题。

英文同理。

@EscapeB
Copy link
Contributor Author

@EscapeB EscapeB commented May 27, 2020

- breadcrumb < a > 标签添加间距
+ 修复 Breadcrumb 内使用链接时图标间距丢失的问题。

英文同理。

sry,漏掉了。已加changelog

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 27, 2020

这个。。。。。。不是 代码里的 changelog

是你 PR 里面的

image

@xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 27, 2020

正确、准确、清晰的描述 PR 里的 changelog ,利于编写新版本发布的 changelog 内容。

@@ -17,6 +17,7 @@ timeline: true

## 4.2.5

- 🐞 修复 Breadcrumb 内使用链接时图标间距丢失的问题。 [#24490](https://github.com/ant-design/ant-design/pull/24490)
Copy link
Member

@afc163 afc163 May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不要改这里,请添加到 PR 的 table 里。

Copy link
Contributor Author

@EscapeB EscapeB May 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好。。我理解错了。

afc163
afc163 approved these changes May 27, 2020
@afc163 afc163 merged commit d5e7187 into ant-design:master May 27, 2020
27 checks passed
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants