Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Avatar.onError() event is triggered twice #24506

Merged
merged 1 commit into from May 27, 2020

Conversation

sanonz
Copy link
Contributor

@sanonz sanonz commented May 27, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

None

💡 Background and solution

The event is triggered twice from bubbling up the DOM tree.
Demo: https://codesandbox.io/s/kind-snow-9lidz

📝 Changelog

Language Changelog
🇺🇸 English Avatar.onError() event is triggered twice
🇨🇳 Chinese Avatar.onError() 事件会触发两次

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 27, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 27, 2020

@codecov
Copy link

@codecov codecov bot commented May 27, 2020

Codecov Report

Merging #24506 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24506   +/-   ##
=======================================
  Coverage   99.10%   99.10%           
=======================================
  Files         363      363           
  Lines        7230     7231    +1     
  Branches     2014     2013    -1     
=======================================
+ Hits         7165     7166    +1     
  Misses         65       65           
Impacted Files Coverage Δ
components/avatar/index.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a13a7...652441f. Read the comment docs.

@afc163 afc163 merged commit f7c34de into ant-design:master May 27, 2020
27 checks passed
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants