Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Progress steps didn't change when update percent #24534

Merged
merged 8 commits into from
May 29, 2020
Merged

fix: Progress steps didn't change when update percent #24534

merged 8 commits into from
May 29, 2020

Conversation

ChuckJonas
Copy link
Contributor

@ChuckJonas ChuckJonas commented May 28, 2020 •
edited by afc163
Loading

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24532

💡 Background and solution

Previously background-color was being set to undefined. I updated the Progress Step component so it just omits the property if the color variable is not set.

📝 Changelog

Language Changelog
🇺🇸 English Fix Progress with steps don't update percent expectedly.
🇨🇳 Chinese 修复步骤 Progress percent 样式未正确更新的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ChuckJonas ChuckJonas changed the title #24532 #24532 Progress with steps does not reverse indicator when moving reducing progress percent May 28, 2020
@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020 •
edited
Loading

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 28, 2020 •
edited
Loading

@codecov
Copy link

codecov bot commented May 28, 2020 •
edited
Loading

Codecov Report

Merging #24534 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24534      +/-   ##
==========================================
- Coverage   99.12%   99.12%   -0.01%     
==========================================
  Files         363      363              
  Lines        7228     7225       -3     
  Branches     1969     2009      +40     
==========================================
- Hits         7165     7162       -3     
  Misses         63       63
Impacted Files Coverage Δ
components/progress/Steps.tsx 100.00% <100.00%> (ø)
components/progress/progress.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf401f7...f972066. Read the comment docs.

@yoyo837 yoyo837 changed the title #24532 Progress with steps does not reverse indicator when moving reducing progress percent fix: #24532 Progress with steps does not reverse indicator when moving reducing progress percent May 28, 2020
@afc163
Copy link
Member

afc163 commented May 28, 2020 •
edited by yoyo837
Loading

补个用例。(Add some test case for this)

@ChuckJonas @yoyo837
Update components/progress/Steps.tsx
6b94d93 
Co-authored-by: Amumu <yoyo837@hotmail.com>
@yoyo837
Copy link
Contributor

yoyo837 commented May 28, 2020 •
edited
Loading

Oops! Incompatible types:

image

@ChuckJonas
Copy link
Contributor Author

ChuckJonas commented May 28, 2020 •
edited
Loading

@yoyo837

Should we just revert your suggestion?

Or is there a different coding style that would be preferred?

afc163
afc163 reviewed May 29, 2020
View reviewed changes
components/progress/style/index.less
transition: all 0.3s;

&-active {
background: @progress-default-color;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

补充默认颜色。

@afc163
Copy link
Member

afc163 commented May 29, 2020

/rebase

@afc163 afc163 changed the title fix: #24532 Progress with steps does not reverse indicator when moving reducing progress percent fix: Progress steps didn't change when update percent May 29, 2020
@afc163 afc163 merged commit 37c894f into ant-design:master May 29, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 left review comments

@yoyo837 yoyo837 yoyo837 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Progress with steps does not reverse indicator when moving reducing progress percent
4 participants
@ChuckJonas @ant-design-bot @afc163 @yoyo837