Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: optimize tree checkbox rtl style #24563

Merged
merged 1 commit into from May 29, 2020
Merged

style: optimize tree checkbox rtl style #24563

merged 1 commit into from May 29, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented May 29, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Before

image

After

image

📝 Changelog

Language Changelog
🇺🇸 English Optimize Tree checkbox style in RTL.
🇨🇳 Chinese 优化 Tree RTL 模式下选项框样式。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed


.@{select-tree-prefix-cls} {
// >>> Checkbox
& &-checkbox {
Copy link
Member

@afc163 afc163 May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
& &-checkbox {
&-checkbox {

这样行么。

Copy link
Member Author

@xrkffgg xrkffgg May 29, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

原有的 就用了这个

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 29, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 29, 2020

@codecov
Copy link

@codecov codecov bot commented May 29, 2020

Codecov Report

Merging #24563 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24563   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         363      363           
  Lines        7364     7364           
  Branches     2059     2051    -8     
=======================================
  Hits         7301     7301           
  Misses         63       63           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11bbd72...fcd692e. Read the comment docs.

@xrkffgg xrkffgg requested a review from afc163 May 29, 2020
@afc163 afc163 merged commit ada8161 into master May 29, 2020
37 checks passed
@afc163 afc163 deleted the opt-treeselect-rtl branch May 29, 2020
@zombieJ zombieJ mentioned this pull request May 31, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants