Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(table): support hideSelectAll and remove hideDefaultSelections in rowSelection(#14581) #24592

Merged
merged 1 commit into from May 29, 2020
Merged

feat(table): support hideSelectAll and remove hideDefaultSelections in rowSelection(#14581) #24592

merged 1 commit into from May 29, 2020

Conversation

kerm1it
Copy link
Member

@kerm1it kerm1it commented May 29, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #14581

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Table support rowSelection.hideSelectAll to hide selectAll checkbox.
🇨🇳 Chinese Table 新增 rowSelection.hideSelectAll 用于隐藏全选框。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/table/demo/row-selection-custom.md
View rendered components/table/index.en-US.md
View rendered components/table/index.zh-CN.md
View rendered docs/react/migration-v4.en-US.md
View rendered docs/react/migration-v4.zh-CN.md

remove hideDefaultSelections prop in rowSelection(#14581);
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 29, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented May 29, 2020

@codecov
Copy link

codecov bot commented May 29, 2020

Codecov Report

Merging #24592 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24592   +/-   ##
=======================================
  Coverage   99.14%   99.14%           
=======================================
  Files         363      363           
  Lines        7363     7364    +1     
  Branches     2012     2057   +45     
=======================================
+ Hits         7300     7301    +1     
  Misses         63       63           
Impacted Files Coverage Δ
components/table/hooks/useSelection.tsx 98.37% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada8161...4560ea0. Read the comment docs.

@kerm1it
Copy link
Member Author

kerm1it commented May 29, 2020

@afc163 你再检查检查,看看有没有问题?

@afc163
Copy link
Member

afc163 commented May 29, 2020

changelog 表格不要删掉,填在里面。

@kerm1it
Copy link
Member Author

kerm1it commented May 29, 2020

changelog 表格不要删掉,填在里面。

OK, 改了,害怕写不下才删除了。

@afc163
Copy link
Member

afc163 commented May 29, 2020

Table 新增 `rowSelection.hideSelectAll` 用于隐藏全选框。

@afc163
Copy link
Member

afc163 commented May 29, 2020

image

这个不需要。

@kerm1it
Copy link
Member Author

kerm1it commented May 29, 2020

image

这个不需要。

changle log的吗?

@afc163
Copy link
Member

afc163 commented May 29, 2020

@kerm1it
Copy link
Member Author

kerm1it commented May 29, 2020

是现在这样么?

@afc163 afc163 merged commit 49533aa into ant-design:master May 29, 2020
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to hide Select All checkbox from the table head
3 participants