Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added Irish(ga_IE) locale #24609

Merged
merged 1 commit into from May 31, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 31, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24586
close #24497

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add Irish(ga_IE) locale
🇨🇳 Chinese 新增爱尔兰语言包。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

🆙 upgrade rc-pagination and rc-picker

🇮🇪 docs and test case of Irish locale
Copy link

@tests-checker tests-checker bot left a comment

Could you please add tests to make sure this change works as expected?

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 31, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 31, 2020

@codecov
Copy link

@codecov codecov bot commented May 31, 2020

Codecov Report

Merging #24609 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24609      +/-   ##
==========================================
+ Coverage   99.12%   99.14%   +0.01%     
==========================================
  Files         363      366       +3     
  Lines        7350     7368      +18     
  Branches     2071     2014      -57     
==========================================
+ Hits         7286     7305      +19     
+ Misses         64       63       -1     
Impacted Files Coverage Δ
components/form/index.tsx 100.00% <ø> (ø)
components/date-picker/locale/ga_IE.tsx 100.00% <100.00%> (ø)
components/locale/ga_IE.tsx 100.00% <100.00%> (ø)
components/time-picker/locale/ga_IE.tsx 100.00% <100.00%> (ø)
components/badge/index.tsx 100.00% <0.00%> (ø)
components/badge/ScrollNumber.tsx 97.22% <0.00%> (+1.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8d4848...d342625. Read the comment docs.

@afc163 afc163 merged commit 9d4d6f5 into master May 31, 2020
37 checks passed
@afc163 afc163 deleted the AbhijeetGaware-abhiAddLanguage29052020 branch May 31, 2020
AbhijeetGaware added a commit to AbhijeetGaware/ant-design that referenced this issue Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants