Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #24614 text button style inconsistent in danger #24622

Merged
merged 3 commits into from Jun 1, 2020

Conversation

morenyang
Copy link
Contributor

@morenyang morenyang commented May 31, 2020

[中文版模板 / Chinese template]

close #24614

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#24614

💡 Background and solution

ezgif com-video-to-gif (1)

Reorder the disabled demo following: normal, text, link
image

📝 Changelog

Language Changelog
🇺🇸 English Fix the inconsistent style of Text Button in danger.
🇨🇳 Chinese 修复 Text Button 在 danger 时样式不一致的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/danger.md
View rendered components/button/demo/disabled.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 31, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented May 31, 2020

@codecov
Copy link

@codecov codecov bot commented May 31, 2020

Codecov Report

Merging #24622 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24622   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         365      365           
  Lines        7278     7278           
  Branches     1986     1986           
=======================================
  Hits         7220     7220           
  Misses         58       58           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a42f77a...8136c2c. Read the comment docs.

@morenyang morenyang changed the title fix: #24614 text button style inconsistent in danger [WIP] fix: #24614 text button style inconsistent in danger May 31, 2020
@morenyang morenyang changed the title [WIP] fix: #24614 text button style inconsistent in danger fix: #24614 text button style inconsistent in danger May 31, 2020
@afc163 afc163 merged commit 9f8eb99 into ant-design:master Jun 1, 2020
26 checks passed
@morenyang morenyang deleted the text-btn-danger-border branch Jun 1, 2020
@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants