Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust notification default place in rtl #24632

Merged
merged 1 commit into from Jun 1, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 1, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

#24566 (comment)

📝 Changelog

Language Changelog
🇺🇸 English Adjust Notification default placement to topLeft in RTL.
🇨🇳 Chinese 调整 Notification RTL 模式下默认弹窗位置为左上。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@codecov
Copy link

@codecov codecov bot commented Jun 1, 2020

Codecov Report

Merging #24632 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24632   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files         365      365           
  Lines        7278     7280    +2     
  Branches     2037     1987   -50     
=======================================
+ Hits         7220     7222    +2     
  Misses         58       58           
Impacted Files Coverage Δ
components/notification/index.tsx 96.93% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03fad91...022190b. Read the comment docs.

@afc163 afc163 merged commit b047add into master Jun 1, 2020
36 of 37 checks passed
@afc163 afc163 deleted the fix-notification-default-place branch Jun 1, 2020
@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants