Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tabs inkbar border lost #24643

Merged
merged 2 commits into from Jun 2, 2020
Merged

fix: tabs inkbar border lost #24643

merged 2 commits into from Jun 2, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 1, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24616

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tabs inkbar border lost when use with react-sticky.
🇨🇳 Chinese 修复 Tabs 配合 react-sticky 使用时下划线遗失问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@xrkffgg xrkffgg requested a review from zombieJ Jun 1, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@codecov
Copy link

@codecov codecov bot commented Jun 1, 2020

Codecov Report

Merging #24643 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24643   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7279     7279           
  Branches     1983     2035   +52     
=======================================
  Hits         7222     7222           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a51439c...924bd31. Read the comment docs.

@@ -25,15 +25,15 @@
// ========================== Top & Bottom ==========================
&.@{tab-prefix-cls}-top,
&.@{tab-prefix-cls}-bottom {
> .@{tab-prefix-cls}-nav {
.@{tab-prefix-cls}-nav {
Copy link
Member

@afc163 afc163 Jun 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个应该在 tabs 内嵌 tabs 的时候有用。

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2020

跑一下这个例子:
截屏2020-06-01 下午6 07 13

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jun 1, 2020

/rebase

@xrkffgg xrkffgg changed the title fix: tabs inkbar border lost [WIP] fix: tabs inkbar border lost Jun 1, 2020
@pr-triage pr-triage bot removed the PR: unreviewed label Jun 1, 2020
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2020

得搞一个 reset 默认重置所有相关的,再附回去……
换成 css in js 就简单多了,可惜现在不是。

@xrkffgg xrkffgg changed the title [WIP] fix: tabs inkbar border lost fix: tabs inkbar border lost Jun 1, 2020
@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jun 1, 2020

Demo 点了点,没问题,不知道这种写法行不行

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jun 1, 2020

@zombieJ 这种不行的话,你来改吧。

@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jun 2, 2020

/rebase

@afc163 afc163 merged commit da0afdf into master Jun 2, 2020
24 of 25 checks passed
@afc163 afc163 deleted the fix-tabs branch Jun 2, 2020
@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
07akioni pushed a commit to 07akioni/ant-design that referenced this issue Jun 4, 2020
* fix: tabs inkbar border lost

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants