Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove dropdownMatchSelectWidth warning #24651

Merged
merged 1 commit into from Jun 1, 2020
Merged

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 1, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Drawer get dropdownMatchSelectWidth as dom prop warning.
🇨🇳 Chinese 修复 Drawer 会报 dom 节点设置 dropdownMatchSelectWidth 的警告信息。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 1, 2020

@codecov
Copy link

@codecov codecov bot commented Jun 1, 2020

Codecov Report

Merging #24651 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24651   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7279     7279           
  Branches     1983     2025   +42     
=======================================
  Hits         7222     7222           
  Misses         57       57           
Impacted Files Coverage Δ
components/drawer/index.tsx 98.86% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ed9b3...ff9f31e. Read the comment docs.

@zombieJ zombieJ merged commit b057518 into master Jun 1, 2020
36 of 37 checks passed
@zombieJ zombieJ deleted the drawer-warning branch Jun 1, 2020
@deligent-ant
Copy link

@deligent-ant deligent-ant commented Jun 1, 2020

no. the warning still exist in v4.3.0

@deligent-ant deligent-ant mentioned this pull request Jun 1, 2020
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jun 1, 2020

not release yet

@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
@yoyo837
Copy link
Contributor

@yoyo837 yoyo837 commented Jun 2, 2020

已发布新版本

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants