Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: btn loading #24678

Merged
merged 1 commit into from Jun 2, 2020
Merged

fix: btn loading #24678

merged 1 commit into from Jun 2, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 2, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24669

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button quick set loading from delay to false will still change to the loading status.
🇨🇳 Chinese 修复 Button 将 loadingdelay 快速切换至 false 时仍然会变成加载状态的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/button/demo/loading.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 2, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 2, 2020

@codecov
Copy link

@codecov codecov bot commented Jun 2, 2020

Codecov Report

Merging #24678 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24678      +/-   ##
==========================================
- Coverage   99.21%   99.21%   -0.01%     
==========================================
  Files         365      365              
  Lines        7279     7277       -2     
  Branches     2025     2032       +7     
==========================================
- Hits         7222     7220       -2     
  Misses         57       57              
Impacted Files Coverage Δ
components/button/button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 351a4d6...e4eeba6. Read the comment docs.

@zombieJ zombieJ merged commit d5fea40 into master Jun 2, 2020
36 of 37 checks passed
@zombieJ zombieJ deleted the btn-loading branch Jun 2, 2020
@zombieJ zombieJ mentioned this pull request Jun 2, 2020
13 tasks
07akioni pushed a commit to 07akioni/ant-design that referenced this issue Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants