Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cal onPanelChange #24695

Merged
merged 3 commits into from Jun 2, 2020
Merged

fix: Cal onPanelChange #24695

merged 3 commits into from Jun 2, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 2, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24636

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Calendar trigger onPanelChange even when in the same panel.
🇨🇳 Chinese 修复 Calendar 在同一个 panel 下也会触发 onPanelChange 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 2, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 2, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 2, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ecfe0ad:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 2, 2020

Codecov Report

Merging #24695 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #24695      +/-   ##
==========================================
- Coverage   99.21%   99.21%   -0.01%     
==========================================
  Files         365      365              
  Lines        7276     7274       -2     
  Branches     1981     1979       -2     
==========================================
- Hits         7219     7217       -2     
  Misses         57       57              
Impacted Files Coverage Δ
components/calendar/generateCalendar.tsx 98.63% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0d75a6...ecfe0ad. Read the comment docs.

@zombieJ zombieJ merged commit d4aca5f into master Jun 2, 2020
38 checks passed
@zombieJ zombieJ deleted the cal-panel branch Jun 2, 2020
07akioni pushed a commit to 07akioni/ant-design that referenced this issue Jun 4, 2020
* simple code

* add test case

* patch
@ycjcl868 ycjcl868 mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants