Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dropdown menu item link color when has icon #24702

Merged
merged 2 commits into from Jun 3, 2020
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24700

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Dropdown menu link color when has icon.
🇨🇳 Chinese 修复 Dropdown 带图标菜单项的链接色彩。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/menu/demo/vertical.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8aba1c1:

Sandbox Source
antd reproduction template Configuration
带图标的连接样式问题 - Ant Design Demo Issue #24700

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 60a2a59:

Sandbox Source
antd reproduction template Configuration
带图标的连接样式问题 - Ant Design Demo Issue #24700

@codecov
Copy link

@codecov codecov bot commented Jun 3, 2020

Codecov Report

Merging #24702 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24702   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7274     7274           
  Branches     2029     2030    +1     
=======================================
  Hits         7217     7217           
  Misses         57       57           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7a950...60a2a59. Read the comment docs.

@afc163 afc163 merged commit cfff796 into master Jun 3, 2020
37 checks passed
@afc163 afc163 deleted the fix-menu-link-color branch Jun 3, 2020
@kaysonwu
Copy link
Contributor

@kaysonwu kaysonwu commented Jun 3, 2020

@afc163 A new color bug will occur when the theme is dark

@afc163 afc163 mentioned this pull request Jun 3, 2020
17 tasks
07akioni pushed a commit to 07akioni/ant-design that referenced this issue Jun 4, 2020
* 🐛 fix Dropdown menu item link color when has icon

close ant-design#24700

* fix snapshot
@ycjcl868 ycjcl868 mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants