Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust select default listItemHeight for small size & compact mode #24706

Merged
merged 1 commit into from Jun 3, 2020

Conversation

AshoneA
Copy link
Contributor

@AshoneA AshoneA commented Jun 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

In compact mode:
image

So adjust default listItemHeight to 24px.(Compact mode and small size height)

📝 Changelog

Language Changelog
🇺🇸 English Fix Select virtual scroll display abnormally in compact mode.
🇨🇳 Chinese 修复 Select 在紧凑模式下表现不正常

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@AshoneA AshoneA requested review from zombieJ and afc163 Jun 3, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@afc163 afc163 merged commit 3ca11e9 into ant-design:master Jun 3, 2020
24 of 25 checks passed
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9620405:

Sandbox Source
antd reproduction template Configuration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants