Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: btn loading 2 twice #24713

Merged
merged 1 commit into from Jun 3, 2020
Merged

fix: btn loading 2 twice #24713

merged 1 commit into from Jun 3, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 3, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24708

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Button loading.delay repeat trigger when parent re-render.
🇨🇳 Chinese 修复 Button 在父阶段重新渲染时 loading.delay 会重复触发的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 3, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 3, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9e45c73:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #24708

@codecov
Copy link

@codecov codecov bot commented Jun 3, 2020

Codecov Report

Merging #24713 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24713   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7275     7278    +3     
  Branches     1979     2031   +52     
=======================================
+ Hits         7218     7221    +3     
  Misses         57       57           
Impacted Files Coverage Δ
components/button/button.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d90c58...9e45c73. Read the comment docs.

@zombieJ zombieJ merged commit 902141f into master Jun 3, 2020
38 checks passed
@zombieJ zombieJ deleted the fix-btn branch Jun 3, 2020
07akioni pushed a commit to 07akioni/ant-design that referenced this issue Jun 4, 2020
@ycjcl868 ycjcl868 mentioned this pull request Jun 5, 2020
@dalaoque
Copy link

@dalaoque dalaoque commented Dec 9, 2020

When using the delay property, who controls the loading state?

Lost spinning?

@afc163 afc163 mentioned this pull request Dec 9, 2020
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants