Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drawer support getPopupContainer and getPrefixCls by ConfigProvider #24727

Merged
merged 3 commits into from Jun 4, 2020

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Jun 4, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

通过 ConfigProvider 设置 getPopupContainer 之后,因为 modal 支持 getPopupContainer,但是
drawer 不支持。导致 drawer 中的 model 显示异常

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 Drawer support set getPopupContainer and getPrefixCls by ConfigProvider
🇨🇳 中文 Drawer 支持通过 ConfigProvider 来全局设置 getPrefixClsgetPopupContainer

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

View rendered components/drawer/demo/config-provider.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 4, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 4, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6c06549:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 4, 2020

Codecov Report

Merging #24727 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24727   +/-   ##
=======================================
  Coverage   99.21%   99.21%           
=======================================
  Files         365      365           
  Lines        7278     7284    +6     
  Branches     2031     1983   -48     
=======================================
+ Hits         7221     7227    +6     
  Misses         57       57           
Impacted Files Coverage Δ
components/drawer/index.tsx 98.93% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d62c44...6c06549. Read the comment docs.

@afc163 afc163 merged commit 6493db8 into master Jun 4, 2020
37 of 38 checks passed
@afc163 afc163 deleted the config-provider branch Jun 4, 2020
@ycjcl868 ycjcl868 mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants