Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tag.CheckableTag don't support onClick #24743

merged 1 commit into from Jun 5, 2020


Copy link

@afc163 afc163 commented Jun 5, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #24733

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tag.CheckableTag don't support onClick.
🇨🇳 Chinese 修复 Tag.CheckableTag 不支持 onClickstopPropagation 的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

@ant-design-bot ant-design-bot commented Jun 5, 2020

Copy link

@ant-design-bot ant-design-bot commented Jun 5, 2020

Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 5, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 725d7d1:

Sandbox Source
antd reproduction template Configuration

Copy link

@codecov codecov bot commented Jun 5, 2020

Codecov Report

Merging #24743 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24743   +/-   ##
  Coverage   99.21%   99.21%           
  Files         365      365           
  Lines        7285     7287    +2     
  Branches     2035     1984   -51     
+ Hits         7228     7230    +2     
  Misses         57       57           
Impacted Files Coverage Δ
components/tag/CheckableTag.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f22c5d9...725d7d1. Read the comment docs.

@afc163 afc163 merged commit 6f36f4a into master Jun 5, 2020
38 checks passed
@afc163 afc163 deleted the fix-tag-on-click branch Jun 5, 2020
@ycjcl868 ycjcl868 mentioned this pull request Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

2 participants