fix: Fixed code that increased package size if tree shaking is disabled #24847
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSichau
changed the title
|
|
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 13e4d56:
|
Codecov Report
@@ Coverage Diff @@
## master #24847 +/- ##
=======================================
Coverage 99.27% 99.27%
=======================================
Files 365 365
Lines 7299 7299
Branches 2041 2042 +1
=======================================
Hits 7246 7246
Misses 53 53
Continue to review full report at Codecov.
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the merged pull request #21752 bundle size was decreased even if tree shaking was disabled. The pull request #24041 destroyed these feature.
With this pull request this is fixed again.
🤔 This is a ...
🔗 Related issue link
#21752
and
#24041
💡 Background and solution
This enables only the import of required icons instead of whole icon library even if tree shaking is disabled.
📝 Changelog
No change on user site.
☑️ Self Check before Merge