Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed code that increased package size if tree shaking is disabled #24847

Merged
merged 1 commit into from Jun 8, 2020

Conversation

DavidSichau
Copy link
Contributor

@DavidSichau DavidSichau commented Jun 8, 2020

With the merged pull request #21752 bundle size was decreased even if tree shaking was disabled. The pull request #24041 destroyed these feature.

With this pull request this is fixed again.

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

#21752
and
#24041

馃挕 Background and solution

This enables only the import of required icons instead of whole icon library even if tree shaking is disabled.

馃摑 Changelog

No change on user site.

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@DavidSichau DavidSichau changed the title Fixed code that increased package size if tree shaking is disabled fix: Fixed code that increased package size if tree shaking is disabled Jun 8, 2020
@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 8, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 8, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 8, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 13e4d56:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 8, 2020

Codecov Report

Merging #24847 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24847   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         365      365           
  Lines        7299     7299           
  Branches     2041     2042    +1     
=======================================
  Hits         7246     7246           
  Misses         53       53           
Impacted Files Coverage 螖
components/transfer/ListItem.tsx 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 862488b...13e4d56. Read the comment docs.

@afc163 afc163 merged commit af5ff52 into ant-design:master Jun 8, 2020
27 checks passed
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants