Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form List warning #24867

Merged
merged 2 commits into from Jun 9, 2020
Merged

fix: Form List warning #24867

merged 2 commits into from Jun 9, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24827

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.List error message display not correct when nested with noStyle.
🇨🇳 Chinese 修复 Form.List 嵌套使用 noStyle 时,错误信息展示混乱的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e94f24cf73a19aed31ef10c44b979b2c4f6d460a:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2a6b15d:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #24867 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24867   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         365      365           
  Lines        7299     7301    +2     
  Branches     2041     1991   -50     
=======================================
+ Hits         7249     7251    +2     
  Misses         50       50           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.15% <100.00%> (ø)
components/form/util.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84381e3...2a6b15d. Read the comment docs.

@zombieJ zombieJ merged commit a9a651f into master Jun 9, 2020
37 checks passed
@zombieJ zombieJ deleted the fix-form-list branch Jun 9, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants