Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add interface for Option props. #24870

Merged
merged 6 commits into from Jun 10, 2020

Conversation

nitinknolder
Copy link
Contributor

@nitinknolder nitinknolder commented Jun 9, 2020

Export option props in the select component.

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #24870 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24870   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         365      365           
  Lines        7299     7299           
  Branches     2041     2041           
=======================================
  Hits         7249     7249           
  Misses         50       50           
Impacted Files Coverage 螖
components/select/index.tsx 97.61% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 84381e3...1e5ab82. Read the comment docs.

@nitinknolder nitinknolder changed the title nitinknolder:export option props Add:export option props Jun 9, 2020
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1e5ab82:

Sandbox Source
antd reproduction template Configuration

components/select/index.tsx Outdated Show resolved Hide resolved
@nitinknolder nitinknolder requested a review from afc163 Jun 9, 2020
@hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Jun 9, 2020

The CI broken because your PR title. See https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json.

components/select/index.tsx Outdated Show resolved Hide resolved
@nitinknolder nitinknolder changed the title Add:export option props Code Refactoring Jun 9, 2020
@nitinknolder nitinknolder changed the title Code Refactoring fix: Add interface for Option props. Jun 9, 2020
@nitinknolder nitinknolder requested a review from afc163 Jun 9, 2020
@afc163 afc163 merged commit b2c359c into ant-design:master Jun 10, 2020
26 checks passed
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants