Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tabs shaking of content #24873

Merged
merged 3 commits into from Jun 9, 2020
Merged

fix: Tabs shaking of content #24873

merged 3 commits into from Jun 9, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24856

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Carousel under Tabs shaking when tab switch.
🇨🇳 Chinese 修复 Carousel 在 Tabs 下切换时会跳跃的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@@ -917,6 +917,7 @@ Array [
>
<div
class="ant-tabs-content ant-tabs-content-top"
style="margin-left:-000%"
Copy link
Member

@afc163 afc163 Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-000%

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 25ac939:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #24856

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #24873 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24873   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         365      365           
  Lines        7301     7301           
  Branches     2032     1991   -41     
=======================================
  Hits         7251     7251           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9a651f...4eb26ef. Read the comment docs.

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4eb26ef:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #24856

@zombieJ zombieJ merged commit 8e66678 into master Jun 9, 2020
37 checks passed
@zombieJ zombieJ deleted the fix-tabs branch Jun 9, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants