Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add @divider-orientation-margin less #24877

Merged
merged 2 commits into from Jun 10, 2020
Merged

style: add @divider-orientation-margin less #24877

merged 2 commits into from Jun 10, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24859

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add @divider-orientation-margin less to control Divider left width when set orientation.
🇨🇳 Chinese 新增 @divider-orientation-margin 变量,用以控制 Divider 设置了 orientation 的左侧距离。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 9, 2020

}
}

&-horizontal&-with-text-right {
&::before {
top: 50%;
width: 95%;
width: 100% - @divider-text-left-width;
Copy link
Member

@afc163 afc163 Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可能不是 left。

Copy link
Member Author

@xrkffgg xrkffgg Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

大佬来起个名~

Copy link
Member

@afc163 afc163 Jun 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divider-orientation-margin

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ace87bf:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 9, 2020

Codecov Report

Merging #24877 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24877   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files         365      365           
  Lines        7301     7301           
  Branches     2041     2042    +1     
=======================================
  Hits         7251     7251           
  Misses         50       50           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e66678...ace87bf. Read the comment docs.

@xrkffgg xrkffgg changed the title style: add @divider-text-left-width less style: add @divider-orientation-margin less Jun 10, 2020
@xrkffgg xrkffgg merged commit d380a8d into master Jun 10, 2020
38 checks passed
@xrkffgg xrkffgg deleted the add-divider-var branch Jun 10, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants