Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getTargetContainer is not omit in Drawer #24938

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jun 12, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix the problem that getTargetContainer is not omit in Drawer.
🇨🇳 Chinese 修正了 getTargetContainer 属性没有在 Drawer 被忽略的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 12, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 12, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 05f770f:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 12, 2020

Codecov Report

Merging #24938 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24938   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         365      365           
  Lines        7303     7303           
  Branches     1992     2042   +50     
=======================================
  Hits         7255     7255           
  Misses         48       48           
Impacted Files Coverage Δ
components/drawer/index.tsx 98.93% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada59b9...05f770f. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Jun 12, 2020

修正了 getTargetContainer 属性没有在 Drawer 被忽略的问题。

🐞 修复 Drawer 报 React does not recognize getTargetContainer prop 的问题。

@afc163 afc163 merged commit ec87ea4 into master Jun 12, 2020
38 checks passed
@afc163 afc163 deleted the fix-drawer-omit-master branch Jun 12, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants