Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove emptyText from TableProps #24948

Merged
merged 1 commit into from Jun 12, 2020
Merged

Conversation

hehex9
Copy link
Contributor

@hehex9 hehex9 commented Jun 12, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

The emptyText props in rc-table has been overridden by locale.emptyText.

📝 Changelog

Language Changelog
🇺🇸 English remove emptyText from TableProps
🇨🇳 Chinese 从 TableProps 中去除 emptyText 定义

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 12, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 12, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5f2225a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 12, 2020

Codecov Report

Merging #24948 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24948   +/-   ##
=======================================
  Coverage   99.34%   99.34%           
=======================================
  Files         365      365           
  Lines        7304     7304           
  Branches     2031     2031           
=======================================
  Hits         7256     7256           
  Misses         48       48           
Impacted Files Coverage Δ
components/table/Table.tsx 99.23% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec87ea4...5f2225a. Read the comment docs.

MrHeer
MrHeer approved these changes Jun 12, 2020
Copy link
Contributor

@MrHeer MrHeer left a comment

Where was removed?

@yoyo837 yoyo837 merged commit ae49280 into ant-design:master Jun 12, 2020
27 checks passed
@07akioni 07akioni mentioned this pull request Jun 14, 2020
@xuniuniu
Copy link

@xuniuniu xuniuniu commented Jun 6, 2022

那用那个来替代呀?现在emptyText

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants