-
-
Notifications
You must be signed in to change notification settings - Fork 52k
fix: List grid not working in React.Fragment or wrapped List.Item #24955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2da908b:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8e1547e:
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit abf7b60:
|
Hi. I'm not sure the best way to report this, but I'm fairly sure this PR represents a regression in how list items are displayed when in grid mode. By wrapping the Edit to add: I should be clear, making the |
), | ||
); | ||
const childrenList = React.Children.map(items, (child: any, index) => ( | ||
<div key={keys[index]} style={colStyle}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the regression I mentioned in my comment.
I think @joelschou is correct, has this been fixed in any future patches? |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #24553
close #24828
💡 Background and solution
📝 Changelog
grid
not working in React.Fragment or wrapped List.Itemgrid
属性在 React.Framgment 或者封装了的 List.Item 上失效的问题。☑️ Self Check before Merge
View rendered components/list/demo/grid-test.md