Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.validateTrigger not work #24979

Merged
merged 2 commits into from Jun 14, 2020
Merged

fix: Form.validateTrigger not work #24979

merged 2 commits into from Jun 14, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 14, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

resolve #24970

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix validateTrigger not works on Form.
🇨🇳 Chinese 修复 Form 中配置 validateTrigger 无效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 14, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 14, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 14, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f6a32e:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 14, 2020

Codecov Report

Merging #24979 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24979   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         365      365           
  Lines        7302     7303    +1     
  Branches     2041     2041           
=======================================
+ Hits         7256     7257    +1     
  Misses         46       46           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.18% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae49280...7f6a32e. Read the comment docs.

@zombieJ zombieJ merged commit 0f46173 into master Jun 14, 2020
38 checks passed
@zombieJ zombieJ deleted the field-context branch Jun 14, 2020
@07akioni 07akioni mentioned this pull request Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants