Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested unbordered table inside a bordered table has border. #24995

Merged
merged 5 commits into from Jun 16, 2020

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jun 15, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #24978

💡 Background and solution

Use > selector.

📝 Changelog

Language Changelog
🇺🇸 English Fix Table: nested unbordered Table inside bordered Table isn't bordered.
🇨🇳 Chinese 修复 Table:嵌套在有边框 Table 的无边框 Table 有边框的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 15, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 15, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 15, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0f0dc4:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 15, 2020

Codecov Report

Merging #24995 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #24995   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files         365      365           
  Lines        7303     7303           
  Branches     1991     2042   +51     
=======================================
  Hits         7257     7257           
  Misses         46       46           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 520fbca...e0f0dc4. Read the comment docs.

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 15, 2020

加一个 debug Demo,做 switch 切换父子 bordered 来测一测。

@zombieJ
Copy link
Member

@zombieJ zombieJ commented Jun 16, 2020

截屏2020-06-16 下午5 36 22

这个c重叠看看能不能优化一下。另外 Demo 里加个 title 和 footer

@07akioni
Copy link
Contributor Author

@07akioni 07akioni commented Jun 16, 2020

截屏2020-06-16 下午5 36 22

这个c重叠看看能不能优化一下。另外 Demo 里加个 title 和 footer

resolved

@zombieJ zombieJ merged commit 8dc1603 into master Jun 16, 2020
37 checks passed
@zombieJ zombieJ deleted the fix-table-nest-border branch Jun 16, 2020
@afc163 afc163 mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants