Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite Password with hooks #25012

Merged
merged 5 commits into from Jun 16, 2020
Merged

refactor: rewrite Password with hooks #25012

merged 5 commits into from Jun 16, 2020

Conversation

hi-rustin
Copy link
Contributor

@hi-rustin hi-rustin commented Jun 16, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

None

💡 Background and solution

Rewrite Password with hooks.

📝 Changelog

Language Changelog
🇺🇸 English rewrite Password with hooks
🇨🇳 Chinese 使用 hooks 重写 Password

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 16, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 16, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7d3ed99:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 16, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f7c4e95:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 16, 2020

Codecov Report

Merging #25012 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25012      +/-   ##
==========================================
+ Coverage   99.37%   99.38%   +0.01%     
==========================================
  Files         365      365              
  Lines        7303     7294       -9     
  Branches     2041     1990      -51     
==========================================
- Hits         7257     7249       -8     
+ Misses         46       45       -1     
Impacted Files Coverage Δ
components/input/Password.tsx 100.00% <100.00%> (+2.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6fe239b...f7c4e95. Read the comment docs.

@hi-rustin hi-rustin marked this pull request as draft Jun 16, 2020
@hi-rustin hi-rustin added this to WIP in Refactor with React Hooks via automation Jun 16, 2020
@hi-rustin hi-rustin marked this pull request as ready for review Jun 16, 2020
@hi-rustin hi-rustin requested review from afc163 and yoyo837 Jun 16, 2020
@hi-rustin
Copy link
Contributor Author

@hi-rustin hi-rustin commented Jun 16, 2020

@afc163 @yoyo837 Pass all tests. Could you please take a look?

@afc163 afc163 merged commit e54df4a into ant-design:master Jun 16, 2020
26 checks passed
Refactor with React Hooks automation moved this from WIP to Done Jun 16, 2020
@afc163 afc163 mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants