Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add empty style for Table empty filters menu #25073

merged 1 commit into from
Jun 18, 2020


Copy link

@afc163 afc163 commented Jun 18, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25068

💡 Background and solution

截屏2020-06-18 上午11 11 49

📝 Changelog

Language Changelog
🇺🇸 English Improve Table empty filters menu UI.
🇨🇳 Chinese 优化 Table 筛选菜单为空时的 UI。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

ant-design-bot commented Jun 18, 2020

Copy link

ant-design-bot commented Jun 18, 2020

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a02289:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25068

Copy link

codecov bot commented Jun 18, 2020

Codecov Report

Merging #25073 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25073   +/-   ##
  Coverage   99.38%   99.38%           
  Files         365      365           
  Lines        7294     7296    +2     
  Branches     2030     2040   +10     
+ Hits         7249     7251    +2     
  Misses         45       45           
Impacted Files Coverage Δ
components/locale/default.tsx 100.00% <ø> (ø)
components/locale/zh_CN.tsx 100.00% <ø> (ø)
components/locale/zh_TW.tsx 100.00% <ø> (ø)
...omponents/table/hooks/useFilter/FilterDropdown.tsx 96.34% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5f3ac8...5a02289. Read the comment docs.

@afc163 afc163 merged commit 1b64eb3 into master Jun 18, 2020
@afc163 afc163 deleted the table-filters-empty branch June 18, 2020 03:38
@afc163 afc163 mentioned this pull request Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Show Empty component when table filter has no data
2 participants