Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix BackTop not hidden completely #25132

Merged
merged 3 commits into from Jun 20, 2020

Conversation

jesse3mh9a
Copy link
Contributor

@jesse3mh9a jesse3mh9a commented Jun 20, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Backtop still interactive when it is hidden.
🇨🇳 Chinese 修复 Backtop 隐藏时仍然影响布局, 尤其是容易触发光标样式

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 20, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 20, 2020

@afc163
Copy link
Member

@afc163 afc163 commented Jun 20, 2020

Try

.ant-back-top:empty {
  display: none;
}

@jesse3mh9a
Copy link
Contributor Author

@jesse3mh9a jesse3mh9a commented Jun 20, 2020

Try

.ant-back-top:empty {
  display: none;
}

嗯 用:empty伪类 会更好 我修改下

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9000e15:

Sandbox Source
antd reproduction template Configuration

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 20, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 222c6be:

Sandbox Source
antd reproduction template Configuration

@jesse3mh9a
Copy link
Contributor Author

@jesse3mh9a jesse3mh9a commented Jun 20, 2020

@afc163 谢谢你的建议, 已经修改完成

@fireairforce
Copy link
Member

@fireairforce fireairforce commented Jun 20, 2020

🤔这个lint挂的好奇怪。。

@afc163 afc163 changed the title style: hidden BackTop still effect layout, such as cursor style: fix BackTop still effect layout, such as cursor Jun 20, 2020
@afc163 afc163 changed the title style: fix BackTop still effect layout, such as cursor style: fix BackTop not hidden completely Jun 20, 2020
@afc163 afc163 merged commit 8b1da1a into ant-design:master Jun 20, 2020
24 of 25 checks passed
@afc163 afc163 mentioned this pull request Jun 21, 2020
@jesse3mh9a jesse3mh9a deleted the backtop-realhidden branch Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants