Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputNumber input in rtl #25146

Merged
merged 1 commit into from Jun 22, 2020
Merged

fix: InputNumber input in rtl #25146

merged 1 commit into from Jun 22, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 22, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

# Pic
Before image
After image

📝 Changelog

Language Changelog
🇺🇸 English Fix InputNumber input inner in RTL.
🇨🇳 Chinese 修复 InputNumber RTL 模式下输入框内显示。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 22, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 22, 2020

@xrkffgg xrkffgg requested a review from saeedrahimi Jun 22, 2020
@xrkffgg
Copy link
Member Author

@xrkffgg xrkffgg commented Jun 22, 2020

@israelKusayev PTAL

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 22, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 410738a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

@codecov codecov bot commented Jun 22, 2020

Codecov Report

Merging #25146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25146   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         365      365           
  Lines        7302     7302           
  Branches     2034     1993   -41     
=======================================
  Hits         7261     7261           
  Misses         41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3663eee...410738a. Read the comment docs.

@afc163 afc163 merged commit 937fa7b into master Jun 22, 2020
37 of 38 checks passed
@afc163 afc163 deleted the fix-inputnumber-rtl branch Jun 22, 2020
@israelKusayev
Copy link
Contributor

@israelKusayev israelKusayev commented Jun 22, 2020

@israelKusayev PTAL

looks good

@chenshuai2144 chenshuai2144 mentioned this pull request Jun 28, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants