Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Menu SubMenu background in dark theme #25205

Merged
merged 1 commit into from Jun 24, 2020
Merged

fix: Menu SubMenu background in dark theme #25205

merged 1 commit into from Jun 24, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 24, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25202

💡 Background and solution

ref #24997

# Pic
Before image
After image

📝 Changelog

Language Changelog
🇺🇸 English Fix Menu.SubMenu background color in dark theme.
🇨🇳 Chinese 修复 Menu theme="dark" 时子菜单背景色为白色的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/menu/demo/horizontal.md
View rendered components/menu/demo/theme.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 24, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 24, 2020

components/menu/style/dark.less Outdated Show resolved Hide resolved
@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1f551260c8417ff6dad458310d202ae1be2865b6:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25202

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 24, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4d9d82b:

Sandbox Source
antd reproduction template Configuration
antd reproduction template Issue #25202

@codecov
Copy link

@codecov codecov bot commented Jun 24, 2020

Codecov Report

Merging #25205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25205   +/-   ##
=======================================
  Coverage   99.43%   99.43%           
=======================================
  Files         365      365           
  Lines        7302     7302           
  Branches     1993     2034   +41     
=======================================
  Hits         7261     7261           
  Misses         41       41           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb586d...4d9d82b. Read the comment docs.

@afc163 afc163 merged commit 87d32a7 into master Jun 24, 2020
38 checks passed
@afc163 afc163 deleted the fix-menu-dark branch Jun 24, 2020
@chenshuai2144 chenshuai2144 mentioned this pull request Jun 28, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants