Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: InputNumber max prop has no default value #25243

Merged
merged 4 commits into from Jun 29, 2020
Merged

Conversation

07akioni
Copy link
Contributor

@07akioni 07akioni commented Jun 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

Set InputNumber max prop default value to Number.MAX_SAFE_INTEGER

📝 Changelog

Language Changelog
🇺🇸 English Fix InputNumber max prop has no default value.
🇨🇳 Chinese 修正 InputNumber max 属性没有默认值的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/input-number/index.en-US.md
View rendered components/input-number/index.zh-CN.md

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 28, 2020

@ant-design-bot
Copy link
Contributor

@ant-design-bot ant-design-bot commented Jun 28, 2020

@codesandbox-ci
Copy link

@codesandbox-ci codesandbox-ci bot commented Jun 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dff15af:

Sandbox Source
antd reproduction template Configuration

@afc163 afc163 mentioned this pull request Jun 29, 2020
13 tasks
@afc163 afc163 merged commit 5c72186 into feature Jun 29, 2020
23 of 29 checks passed
@afc163 afc163 deleted the fix-input-number-max branch Jun 29, 2020
github-actions bot pushed a commit that referenced this issue Jun 29, 2020
chenshuai2144 added a commit that referenced this issue Jun 29, 2020
* docs: add 4.3.6 changelog

* add 25244 changelog

* fix review

* update changelog

* update changelog

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: 偏右 <afc163@gmail.com>

* sort log

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update changelog

* sort log

* sort log

* add #25266 #25243 #25254 #25271 changelog

* add #25273 changelog

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* sort logs

* Update CHANGELOG.zh-CN.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* up versin

* Update changelog

* close react/no-unused-prop-types

* update changelog

* update snapshot

* Update CHANGELOG.en-US.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update snapshot

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update changelog

* clear Duplicate

* sort logs

Co-authored-by: xrkffgg <xrkffgg@gmail.com>
Co-authored-by: 偏右 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants