-
-
Notifications
You must be signed in to change notification settings - Fork 49.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: InputNumber max prop has no default value #25243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dff15af:
|
xrkffgg
approved these changes
Jun 28, 2020
fireairforce
approved these changes
Jun 28, 2020
07akioni
force-pushed
the
fix-input-number-max
branch
from
June 29, 2020 02:28
70d98a7
to
a2d9f70
Compare
chenshuai2144
added a commit
that referenced
this pull request
Jun 29, 2020
* docs: add 4.3.6 changelog * add 25244 changelog * fix review * update changelog * update changelog * Update CHANGELOG.en-US.md Co-authored-by: xrkffgg <xrkffgg@gmail.com> * Update CHANGELOG.en-US.md Co-authored-by: xrkffgg <xrkffgg@gmail.com> * Update CHANGELOG.en-US.md Co-authored-by: xrkffgg <xrkffgg@gmail.com> * Update CHANGELOG.en-US.md Co-authored-by: 偏右 <afc163@gmail.com> * sort log * Update CHANGELOG.zh-CN.md Co-authored-by: 偏右 <afc163@gmail.com> * update changelog * sort log * sort log * add #25266 #25243 #25254 #25271 changelog * add #25273 changelog * Update CHANGELOG.en-US.md Co-authored-by: xrkffgg <xrkffgg@gmail.com> * Update CHANGELOG.zh-CN.md Co-authored-by: 偏右 <afc163@gmail.com> * sort logs * Update CHANGELOG.zh-CN.md Co-authored-by: xrkffgg <xrkffgg@gmail.com> * up versin * Update changelog * close react/no-unused-prop-types * update changelog * update snapshot * Update CHANGELOG.en-US.md Co-authored-by: 偏右 <afc163@gmail.com> * update snapshot * Update CHANGELOG.zh-CN.md Co-authored-by: 偏右 <afc163@gmail.com> * update changelog * clear Duplicate * sort logs Co-authored-by: xrkffgg <xrkffgg@gmail.com> Co-authored-by: 偏右 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
Set InputNumber max prop default value to
Number.MAX_SAFE_INTEGER
📝 Changelog
max
prop has no default value.max
属性没有默认值的问题。☑️ Self Check before Merge
View rendered components/input-number/index.en-US.md
View rendered components/input-number/index.zh-CN.md