Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add BackTop duration #25254

Merged
merged 1 commit into from Jun 29, 2020
Merged

feat: add BackTop duration #25254

merged 1 commit into from Jun 29, 2020

Conversation

xrkffgg
Copy link
Member

@xrkffgg xrkffgg commented Jun 28, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #25251

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Add BackTop duration used to set the time required to return to the top.
🇨🇳 Chinese 增加 BackTop duration 用来设置回到顶部所需时间。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 28, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 28, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 28, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2820c0:

Sandbox Source
antd reproduction template Configuration

@@ -68,9 +69,10 @@ const BackTop: React.FC<BackTopProps> = props => {
};

const scrollToTop = (e: React.MouseEvent<HTMLDivElement>) => {
const { onClick, target } = props;
const { onClick, target, duration = 450 } = props;
scrollTo(0, {
Copy link
Member Author

@xrkffgg xrkffgg Jun 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 0 要不要也提出来,可以设置 回到的位置

@xrkffgg
Copy link
Member Author

xrkffgg commented Jun 29, 2020

/rebase

@github-actions github-actions bot force-pushed the feat-backtop-duration-a branch from 41e22d8 to b2820c0 Compare Jun 29, 2020
@afc163 afc163 mentioned this pull request Jun 29, 2020
13 tasks
afc163
afc163 approved these changes Jun 29, 2020
@afc163 afc163 merged commit 8a846de into feature Jun 29, 2020
12 of 14 checks passed
@afc163 afc163 deleted the feat-backtop-duration-a branch Jun 29, 2020
@xrkffgg
Copy link
Member Author

xrkffgg commented Jun 29, 2020

这个的 文档 API 我 补到 feature 还是 master ? @afc163

@afc163
Copy link
Member

afc163 commented Jun 29, 2020

feature 吧

@xrkffgg xrkffgg mentioned this pull request Jun 29, 2020
17 tasks
github-actions bot pushed a commit that referenced this pull request Jun 29, 2020
chenshuai2144 added a commit that referenced this pull request Jun 29, 2020
* docs: add 4.3.6 changelog

* add 25244 changelog

* fix review

* update changelog

* update changelog

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.en-US.md

Co-authored-by: 偏右 <afc163@gmail.com>

* sort log

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update changelog

* sort log

* sort log

* add #25266 #25243 #25254 #25271 changelog

* add #25273 changelog

* Update CHANGELOG.en-US.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* sort logs

* Update CHANGELOG.zh-CN.md

Co-authored-by: xrkffgg <xrkffgg@gmail.com>

* up versin

* Update changelog

* close react/no-unused-prop-types

* update changelog

* update snapshot

* Update CHANGELOG.en-US.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update snapshot

* Update CHANGELOG.zh-CN.md

Co-authored-by: 偏右 <afc163@gmail.com>

* update changelog

* clear Duplicate

* sort logs

Co-authored-by: xrkffgg <xrkffgg@gmail.com>
Co-authored-by: 偏右 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants