Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: FormItem help message's animation has no deadline #25297

merged 1 commit into from Jun 30, 2020


Copy link

@07akioni 07akioni commented Jun 30, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #23443

💡 Background and solution

Add motionDeadline on CSSMotion.

📝 Changelog

Language Changelog
🇺🇸 English Fix FormItem help message may not disappear in a display:none container.
🇨🇳 Chinese 修正 FormItem 在 display: none 的容器中提示信息可能不会消失的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Copy link

ant-design-bot commented Jun 30, 2020

Copy link

ant-design-bot commented Jun 30, 2020

Copy link

codesandbox-ci bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4fe49c9:

Sandbox Source
antd reproduction template Configuration

Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #25297 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25297   +/-   ##
  Coverage   99.51%   99.51%           
  Files         368      368           
  Lines        7286     7286           
  Branches     2042     2044    +2     
  Hits         7251     7251           
  Misses         35       35           
Impacted Files Coverage Δ
components/form/FormItemInput.tsx 94.11% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50ae25d...4fe49c9. Read the comment docs.

@zombieJ zombieJ merged commit 53b232d into master Jun 30, 2020
38 checks passed
@zombieJ zombieJ deleted the fix-form-item-animation branch Jun 30, 2020
@zombieJ zombieJ mentioned this pull request Jul 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
3 participants