Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sketch.Button default width #25303

Merged
merged 1 commit into from Jun 30, 2020
Merged

fix: Sketch.Button default width #25303

merged 1 commit into from Jun 30, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 30, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

https://codesandbox.io/s/mutable-voice-5ovbg

image

should be inline-block.

image

📝 Changelog

Language Changelog
🇺🇸 English Fix Skeleton Button/Avatar/Input/Image default width to auto.
🇨🇳 Chinese 修复 Skeleton Button/Avatar/Input/Image 默认宽度为 auto。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/skeleton/demo/element.md
View rendered components/skeleton/demo/list.md

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f233e0:

Sandbox Source
antd reproduction template Configuration
compassionate-moon-uiuci PR

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #25303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25303   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7290     7290           
  Branches     2044     1995   -49     
=======================================
  Hits         7255     7255           
  Misses         35       35           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb57ae...8f233e0. Read the comment docs.

Copy link
Contributor

@hi-rustin hi-rustin left a comment

LGTM

@hi-rustin hi-rustin merged commit d401dfe into master Jun 30, 2020
37 of 38 checks passed
@hi-rustin hi-rustin deleted the skeleton-demo branch Jun 30, 2020
@afc163 afc163 mentioned this pull request Jul 6, 2020
13 tasks
@zombieJ zombieJ mentioned this pull request Jul 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants