Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip custom color typescript type definition #25315

Merged
merged 1 commit into from Jul 1, 2020

Conversation

CornerSkyless
Copy link
Contributor

@CornerSkyless CornerSkyless commented Jun 30, 2020

🤔 这个变动的性质是?

  • 新特性提交
  • 日常 bug 修复
  • 站点、文档改进
  • 演示代码改进
  • 组件样式改进
  • TypeScript 定义更新
  • 包体积优化
  • 性能优化
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

在TypeScript版本中使用Tooltip 自定义color属性(如#099999),代码检查报错

Issue 链接

close #25015

💡 需求背景和解决方案

将 Tooltip 中 color 定义由

color?: PresetColorType;

变为

color?: LiteralUnion<PresetColorType, string>;

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文 fix Tooltip custom color typescript type definition
🇨🇳 中文 修复 Tooltip 自定义颜色 Typescript 定义错误

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

首次尝试提交 PR :)

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 165cad3:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #25315 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25315   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7290     7290           
  Branches     2042     2042           
=======================================
  Hits         7255     7255           
  Misses         35       35           
Impacted Files Coverage Δ
components/tooltip/index.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c548a...165cad3. Read the comment docs.

@afc163 afc163 merged commit 1da3144 into ant-design:master Jul 1, 2020
27 checks passed
@zombieJ zombieJ mentioned this pull request Jul 6, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants