Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ResponsiveObserve unsubscribe (#25309) #25319

Merged
merged 4 commits into from Jul 2, 2020

Conversation

zhangchen915
Copy link
Contributor

@zhangchen915 zhangchen915 commented Jun 30, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#25309

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Grid ResponsiveObserve not been unsubscribed correctly.
🇨🇳 Chinese 修复 Grid 响应式监听函数没有正确销毁的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jun 30, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0f1535a:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #25319 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #25319      +/-   ##
==========================================
+ Coverage   99.51%   99.53%   +0.01%     
==========================================
  Files         368      368              
  Lines        7290     7287       -3     
  Branches     2042     1994      -48     
==========================================
- Hits         7255     7253       -2     
+ Misses         35       34       -1     
Impacted Files Coverage Δ
components/grid/row.tsx 100.00% <ø> (ø)
components/_util/responsiveObserve.ts 100.00% <100.00%> (+2.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70c548a...0f1535a. Read the comment docs.

components/_util/responsiveObserve.ts Outdated Show resolved Hide resolved
components/_util/responsiveObserve.ts Outdated Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented Jul 1, 2020

方便加测试么?

@zhangchen915
Copy link
Contributor Author

zhangchen915 commented Jul 1, 2020

好的,我加一下单测

@afc163 afc163 merged commit 26fa360 into ant-design:master Jul 2, 2020
26 checks passed
This was referenced Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants