Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Form.Item hidden no working #25336

Merged
merged 1 commit into from Jul 1, 2020
Merged

fix: Form.Item hidden no working #25336

merged 1 commit into from Jul 1, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 1, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Perfermance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #25335

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Form.Item hidden no working.
🇨🇳 Chinese 修复 Form.Item hidden 属性不生效的问题。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Jul 1, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 1, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c6ccf33:

Sandbox Source
antd reproduction template Configuration

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #25336 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #25336   +/-   ##
=======================================
  Coverage   99.51%   99.51%           
=======================================
  Files         368      368           
  Lines        7290     7290           
  Branches     2042     2044    +2     
=======================================
  Hits         7255     7255           
  Misses         35       35           
Impacted Files Coverage Δ
components/form/FormItem.tsx 99.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2575a4f...c6ccf33. Read the comment docs.

@afc163 afc163 merged commit 5b7104c into master Jul 1, 2020
38 checks passed
@afc163 afc163 deleted the fix-form-item-hidden branch Jul 1, 2020
afc163 added a commit that referenced this issue Jul 1, 2020
@@ -66,10 +66,6 @@
margin-bottom: 0;
}

&-hidden {
display: none;
}
Copy link
Member Author

@afc163 afc163 Jul 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

删错了,这里加回来了 7b9231a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants